Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement emergency proposal #15

Merged
merged 6 commits into from
Nov 17, 2023
Merged

feat: implement emergency proposal #15

merged 6 commits into from
Nov 17, 2023

Conversation

beer-1
Copy link
Contributor

@beer-1 beer-1 commented Nov 16, 2023 •
edited
Loading

Introduce two params:

  • EmergencyMinDeposit: deposit required to make a proposal to emergency proposal
  • EmergencyTallyInterval: chain will do tally operation periodically for the all emergency proposals in this interval.

Two queries:

  • EmergencyProposals
  • LastEmergencyProposalTallyTimestamp

@beer-1 beer-1 requested a review from a team as a code owner November 16, 2023 08:38
@beer-1 beer-1 self-assigned this Nov 16, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 16, 2023 •
edited
Loading

Codecov Report

Merging #15 (7b12cdf) into main (d22ddac) will decrease coverage by 2.45%.
The diff coverage is 72.79%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
- Coverage   46.90%   44.46%   -2.45%     
==========================================
  Files         148      165      +17     
  Lines       14590    15994    +1404     
==========================================
+ Hits         6844     7111     +267     
- Misses       6984     8103    +1119     
- Partials      762      780      +18
Files Coverage Δ
app/genesis.go 43.00% <100.00%> (+0.57%) ⬆️
x/gov/keeper/params.go 64.70% <100.00%> (ø)
x/move/keeper/staking.go 62.36% <ø> (ø)
x/gov/keeper/msg_server.go 0.00% <0.00%> (ø)
x/gov/keeper/proposal.go 27.09% <92.85%> (ø)
x/gov/types/keys.go 0.00% <0.00%> (ø)
x/gov/keeper/custom_msg_server.go 72.72% <72.72%> (ø)
x/gov/keeper/custom_grpc_query.go 84.84% <84.84%> (ø)
x/gov/types/params.go 93.54% <93.54%> (ø)
x/gov/keeper/tally.go 0.00% <0.00%> (ø)
... and 5 more

... and 4 files with indirect coverage changes

@beer-1 beer-1 merged commit e382d93 into main Nov 17, 2023
6 of 7 checks passed
@beer-1 beer-1 deleted the feat/emergency-proposal branch November 17, 2023 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@beer-1 beer-1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@beer-1